Skip to content

fix graphs/greedy_best_first #8771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 12 commits into from
Closed

fix graphs/greedy_best_first #8771

wants to merge 12 commits into from

Conversation

JadeKim042386
Copy link
Contributor

@JadeKim042386 JadeKim042386 commented May 26, 2023 •
edited
Loading

Describe your change:

#8770

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@algorithms-keeper algorithms-keeper bot added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed tests are failing Do not merge until tests pass labels May 26, 2023
@algorithms-keeper algorithms-keeper bot removed the tests are failing Do not merge until tests pass label May 26, 2023
@cclauss
Rename is_palindrome.py to is_int_palindrome.py (TheAlgorithms#8768)
dd3b499 
* Rename is_palindrome.py to is_int_palindrome.py

* updating DIRECTORY.md

---------

Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
@tianyizheng02
Copy link
Contributor

There doesn't seem to have been any tests for the individual class methods. We definitely wanna avoid letting such code mistakes go unnoticed/untested, so could you add some tests to the file? Preferably testing various example inputs for each method in order to avoid having a bug pass through due to some oversight in the examples.

@cclauss @dhruvmanila @pre-commit-ci
Add more ruff rules (TheAlgorithms#8767)
4b79d77 
* Add more ruff rules

* Add more ruff rules

* pre-commit: Update ruff v0.0.269 -> v0.0.270

* Apply suggestions from code review

* Fix doctest

* Fix doctest (ignore whitespace)

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: Dhruv Manilawala <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@JadeKim042386 JadeKim042386 changed the title fix another typo in graphs/greedy_best_first fix graphs/greedy_best_first May 27, 2023
@algorithms-keeper algorithms-keeper bot added the tests are failing Do not merge until tests pass label May 27, 2023
@JadeKim042386
Copy link
Contributor Author

i added some tests and found other problems.
i renewed #8770, so please check it.

@JadeKim042386
Copy link
Contributor Author

😱 i.....i made a mistake. i pushed it wrong

@JadeKim042386 JadeKim042386 mentioned this pull request May 27, 2023
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss Awaiting requested review from cclauss cclauss is a code owner

@dhruvmanila dhruvmanila Awaiting requested review from dhruvmanila

Assignees
No one assigned
Labels
awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files tests are failing Do not merge until tests pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JadeKim042386 @tianyizheng02 @jjweng123 @cclauss